eden-emu/libusb
20
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

examples: Fix format-truncation on debug

Browse source 
As description is used only for debug, we can extend it to be sure to
fit 256 from string variable plus 3 chars from " - " as described in
gcc warning below

 | testlibusb.c: In function ‘print_device.constprop’:
 | testlibusb.c:188:51: warning: ‘ - ’ directive output may be truncated writing 3 bytes into a region of size between 1 and 256 [-Wformat-truncation=]
 |      snprintf(description, sizeof(description), "%s - ", string);
 |                                                    ^~~
 | testlibusb.c:188:5: note: ‘snprintf’ output between 4 and 259 bytes into a destination of size 256
 |      snprintf(description, sizeof(description), "%s - ", string);
 |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Closes #460

Signed-off-by: Victor Toso <victortoso@redhat.com>

Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
This commit is contained in:
Victor Toso 2018-08-07 09:45:58 +02:00 • committed by Nathan Hjelm
parent e8e80368b7
commit fcf9a53595
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
examples/testlibusb.c
View file

@ -169,7 +169,7 @@ static int print_device(libusb_device *dev, int level)
{
struct libusb_device_descriptor desc;
libusb_device_handle *handle = NULL;
char description[256];
char description[260];
char string[256];
int ret;
uint8_t i;