From fcf9a53595882149ebe3adfe833cd6ade2ce7e31 Mon Sep 17 00:00:00 2001 From: Victor Toso Date: Tue, 7 Aug 2018 09:45:58 +0200 Subject: [PATCH] examples: Fix format-truncation on debug MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As description is used only for debug, we can extend it to be sure to fit 256 from string variable plus 3 chars from " - " as described in gcc warning below | testlibusb.c: In function ‘print_device.constprop’: | testlibusb.c:188:51: warning: ‘ - ’ directive output may be truncated writing 3 bytes into a region of size between 1 and 256 [-Wformat-truncation=] | snprintf(description, sizeof(description), "%s - ", string); | ^~~ | testlibusb.c:188:5: note: ‘snprintf’ output between 4 and 259 bytes into a destination of size 256 | snprintf(description, sizeof(description), "%s - ", string); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Closes #460 Signed-off-by: Victor Toso Signed-off-by: Nathan Hjelm --- examples/testlibusb.c | 2 +- libusb/version_nano.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/testlibusb.c b/examples/testlibusb.c index f844aaf8..6501a121 100755 --- a/examples/testlibusb.c +++ b/examples/testlibusb.c @@ -169,7 +169,7 @@ static int print_device(libusb_device *dev, int level) { struct libusb_device_descriptor desc; libusb_device_handle *handle = NULL; - char description[256]; + char description[260]; char string[256]; int ret; uint8_t i; diff --git a/libusb/version_nano.h b/libusb/version_nano.h index 76794377..0ffedb5f 100644 --- a/libusb/version_nano.h +++ b/libusb/version_nano.h @@ -1 +1 @@ -#define LIBUSB_NANO 11323 +#define LIBUSB_NANO 11324