eden-emu/eden
14
3
Fork 4
Code Issues 3 Pull requests 2 Projects Releases 2 Packages Wiki Activity Actions 4
16599 commits 7 branches 3 tags 180 MiB
Commit graph

16599 commits

This branch
This branch
All branches
Author SHA1 Message Date
ReinUsesLisp
eff4da93e1 common/file_util: Let std::filesystem cast from UTF16 to std::string 
Fix invalid encoding paths when iterating over a directory on Windows.
 2020-12-09 18:52:36 -03:00
Chloe
586d5a72e1 Merge pull request #5176 from Morph1984/fix-createfile 
vfs_real: Fix CreateFile for files without a file extension
 2020-12-09 22:47:03 +11:00
Morph
b8c2935580 vfs_real: Fix CreateFile for files without a file extension 2020-12-09 06:34:49 -05:00
Morph
1f5f5d8d3c Merge pull request #5174 from ReinUsesLisp/fs-fix 
common/file_util: Fix and deprecate CreateFullPath, add CreateDirs
 2020-12-09 18:07:44 +08:00
ReinUsesLisp
443d8d3a23 common/file_util: Fix and deprecate CreateFullPath, add CreateDirs 
Fix CreateFullPath to have its intended previous behavior (whatever
that was), and deprecate it in favor of the new CreateDirs function.

Unlike CreateDir, CreateDirs is marked as [[nodiscard]] to avoid new
code ignoring its result value.
 2020-12-09 05:42:03 -03:00
ReinUsesLisp
74e078db55 common/file_util: Succeed on CreateDir when the directory exists 2020-12-09 05:21:08 -03:00
Rodrigo Locatti
714b347f96 Merge pull request #5142 from comex/xx-poll-events 
network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an `enum class PollEvents`
 2020-12-09 03:52:20 -03:00
Rodrigo Locatti
65c2816e9e Merge pull request #5173 from lioncash/common-fs 
common/file_util: Make use of std::filesystem
 2020-12-09 03:47:21 -03:00
Lioncash
3b79d189d3 file_util: Migrate remaining file handling functions over to std::filesystem 
Converts creation and deletion functions over to std::filesystem,
simplifying our file-handling code.

Notably with this, CopyDir will now function on Windows.
 2020-12-09 01:24:05 -05:00
bunnei
f923f9b6d0 Merge pull request #5166 from lioncash/log-cast 
core: Remove unnecessary enum casts in log calls
 2020-12-08 21:58:13 -08:00
bunnei
851af116b2 Merge pull request #5135 from Morph1984/applets-shadow 
applets: Resolve variable shadowing
 2020-12-08 17:43:59 -08:00
Lioncash
df7cf1df19 file_util: Migrate Exists() and IsDirectory() over to std::filesystem 
Greatly simplifies our file-handling code for these functions.
 2020-12-08 18:36:53 -05:00
LC
026a2e35c2 Merge pull request #5171 from lat9nq/ci-unicorn-cleanup 
ci: Remove `-DYUZU_USE_BUNDLED_UNICORN=ON`
 2020-12-08 15:14:53 -05:00
lat9nq
7459d47cb6 ci: Remove -DYUZU_USE_BUNDLED_UNICORN=ON 
Unicorn has been removed, yet CI still enables building with Unicorn.
This just cleans up a few leftovers by removing the variable from the
CMake parameters in CI.
 2020-12-08 15:06:02 -05:00
bunnei
c0ac666e2f Merge pull request #5167 from lioncash/doc-memory 
memory: Resolve -Wdocumentation warning for Write()
 2020-12-08 11:47:04 -08:00
Lioncash
024c10b697 memory: Resolve -Wdocumentation warning for Write() 
Write() doesn't return anything, so the @returns tag shouldn't be
present.
 2020-12-08 12:44:58 -05:00
bunnei
c9d7c96b27 Merge pull request #5156 from comex/xx-raws 
configure_motion_touch: Fix unescaped backslash in regex
 2020-12-08 09:39:47 -08:00
Morph
8aa4a6d501 Merge pull request #5165 from lioncash/copy-controller 
controller: Avoid unnecessary copies in ConfigurationComplete()
 2020-12-08 20:48:45 +08:00
Lioncash
8f135703dc core: Remove unnecessary enum casts in log calls 
Follows the video core PR. fmt doesn't require casts for enum classes
anymore, so we can remove quite a few casts.
 2020-12-07 23:02:23 -05:00
Lioncash
fb0e41b085 controller: Use std::move within ConvertToFrontendParameters() 
Avoids unnecessary copies.
 2020-12-07 22:04:16 -05:00
Lioncash
b3a31de3b9 controller: Avoid unnecessary copies in ConfigurationComplete() 
Avoids unnecessary 1072 byte copies when querying info about
controllers.
 2020-12-07 22:02:58 -05:00
Morph
439488a842 Merge pull request #5020 from german77/AnalogfromButtonFix 
Disable analog joystick from buttons by default
 2020-12-08 10:30:21 +08:00
german
1a3e4518ec Disable analog joystick from buttons by default 2020-12-07 19:34:52 -06:00
Rodrigo Locatti
bbf78a6df7 Merge pull request #5164 from lioncash/contains 
video_core: Make use of ordered container contains() where applicable
 2020-12-07 21:55:51 -03:00
Rodrigo Locatti
f80d120d67 Merge pull request #5163 from lioncash/concat 
ast: Improve string concat readability in operator()
 2020-12-07 21:55:21 -03:00
bunnei
1613bbab8a Merge pull request #5153 from comex/xx-unix 
CMakeLists,network: Create YUZU_UNIX macro to replace __unix__
 2020-12-07 15:32:06 -08:00
Lioncash
909671a055 video_core: Make use of ordered container contains() where applicable 
With C++20, we can use the more concise contains() member function
instead of comparing the result of the find() call with the end
iterator.
 2020-12-07 16:30:39 -05:00
Lioncash
4d6a2247f2 ast: Improve string concat readability in operator() 
Provides an in-place format string to make it more pleasant to read.
 2020-12-07 16:15:28 -05:00
bunnei
72378f4f6c Merge pull request #5149 from comex/xx-map-interval 
map_interval: Change field order to address uninitialized field warning
 2020-12-07 10:14:02 -08:00
Rodrigo Locatti
73f3e1cbf3 Merge pull request #5159 from lioncash/move-amend 
shader_ir: std::move node within DeclareAmend()
 2020-12-07 04:58:01 -03:00
Rodrigo Locatti
4cab52f258 Merge pull request #5160 from lioncash/buffer-header 
buffer_block: Remove unnecessary includes
 2020-12-07 04:57:40 -03:00
Lioncash
4704a22c3f buffer_block: Mark interface as nodiscard where applicable 
Prevents logic errors from occurring from unused values.
 2020-12-07 01:53:40 -05:00
Lioncash
7caec76970 buffer_block: Remove unnecessary includes 
Reduces the amount of dependencies the header pulls in.
 2020-12-07 01:52:16 -05:00
Rodrigo Locatti
81249bc311 Merge pull request #5158 from lioncash/video-fmt 
video_core: Remove unnecessary enum class casting in logging messages
 2020-12-07 03:35:25 -03:00
bunnei
9ba99af200 Merge pull request #5148 from comex/xx-unused-fields 
core: Mark unused fields as [[maybe_unused]]
 2020-12-06 22:33:00 -08:00
bunnei
6324f1e67f Merge pull request #5154 from comex/xx-ipc 
hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp
 2020-12-06 22:32:04 -08:00
Lioncash
0e7ead8b49 shader_ir: std::move node within DeclareAmend() 
Same behavior, but elides an unnecessary atomic reference count
increment and decrement.
 2020-12-07 00:51:03 -05:00
Lioncash
ea0e85b869 video_core: Remove unnecessary enum class casting in logging messages 
fmt now automatically prints the numeric value of an enum class member
by default, so we don't need to use casts any more.

Reduces the line noise a bit.
 2020-12-07 00:41:50 -05:00
LC
7694cb9154 Merge pull request #5147 from comex/xx-purevirt 
nvdrv: Remove useless re-declaration of pure virtual methods that were already declared in the superclass
 2020-12-07 00:08:46 -05:00
LC
5afcc5fb3d Merge pull request #5150 from comex/xx-boxcat 
boxcat: Avoid unnecessary object copy
 2020-12-07 00:07:39 -05:00
LC
f2ca2f4412 Merge pull request #5152 from comex/xx-override 
renderer_vulkan: Add missing `override` specifier
 2020-12-07 00:07:17 -05:00
LC
60ba2d11df Merge pull request #5136 from lioncash/video-shadow3 
video_core: Resolve more variable shadowing scenarios pt.3
 2020-12-07 00:06:53 -05:00
comex
14f8c5e6fe configure_motion_touch: Fix unescaped backslash in regex 
Since this is inside a string literal, backslashes that are part of
regex syntax have to be escaped.  But that's ugly, so convert to a raw
string instead.
 2020-12-06 19:25:48 -05:00
comex
f5937952aa network, sockets: Replace POLL_IN, POLL_OUT, etc. constants with an enum class PollEvents 
Actually, two enum classes, since for some reason there are two separate
yet identical `PollFD` types used in the codebase.  I get that one is
ABI-compatible with the Switch while the other is an abstract type used
for the host, but why not use `WSAPOLLFD` directly for the latter?

Anyway, why make this change?  Because on Apple platforms, `POLL_IN`,
`POLL_OUT`, etc. (with an underscore) are defined as macros in
<sys/signal.h>.  (This is inherited from FreeBSD.)  So defining
a variable with the same name causes a compile error.

I could just rename the variables, but while I was at it I thought I
might as well switch to an enum for stronger typing.

Also, change the type used for values copied directly to/from the
`events` and `revents` fields of the host *native*
`pollfd`/`WSASPOLLFD`, from `u32` to `short`, as `short` is the correct
canonical type on both Unix and Windows.
 2020-12-06 19:14:42 -05:00
LC
7aa6cf6b41 Merge pull request #5155 from comex/xx-default 
Fix "explicitly defaulted but implicitly deleted" warning
 2020-12-06 19:05:39 -05:00
comex
086238f1ac Fix "explicitly defaulted but implicitly deleted" warning 
`PhysicalCore`'s move assignment operator was declared as `= default`,
but was implicitly deleted because `PhysicalCore` has fields
of reference type.  Switch to explicitly deleting it to avoid a Clang
warning.

The move *constructor* is still defaulted, and is required to exist due
to the use of `std::vector<PhysicalCore>`.
 2020-12-06 19:02:04 -05:00
comex
63994da5c3 hle: Type check ResponseBuilder::Push arguments, and fix use in vi.cpp 
- Add a type check so that calling Push with an invalid type produces a
  compile error rather than a linker error.

- vi.cpp was calling Push with a variable of type `std::size_t`.
  There's no explicit overload for `size_t`, but there is one for `u64`,
  which on most platforms is the same type as `size_t`.  On macOS,
  however, it isn't: both types are 64 bits, but `size_t` is `unsigned
  long` and `u64` is `unsigned long long`.  Regardless, it makes more
  sense to explicitly use `u64` here instead of `size_t`.
 2020-12-06 18:59:22 -05:00
comex
3c7962df41 CMakeLists,network: Create YUZU_UNIX macro to replace __unix__ 
__unix__ is not predefined on Apple platforms even though they are Unix.
 2020-12-06 18:56:40 -05:00
comex
2451a59949 renderer_vulkan: Add missing override specifier 2020-12-06 18:38:52 -05:00
comex
ef14bbc69d map_interval: Change field order to address uninitialized field warning 
Clang complains about `new_chunk`'s constructor using the
then-uninitialized `first_chunk` (even though it's just to get a pointer
into it).
 2020-12-06 18:37:23 -05:00