Commit graph

3269 commits

Author SHA1 Message Date
Ralph Giles
0431f93355 Improve Content Type figure placement.
With xml2rfc 2.3.9, I was getting the 'audio/ogg; codecs=opus'
figure hoisted out of the the containing paragraph, which was
very confusing.

I've tried to improve this by moving the surrounding paragraph
into the figure using the <preamble> and <postamble> tags, as
in the example in draft-mrose-writting-rfcs.

Unfortunately this still isn't perfect. Since the surrounding
paragraph is part of the figure we can't set align="center" on
the figure itself, and the processor seems to ignore it on the
artwork element. I've compensated by adding some leading
whitespace.
2013-01-16 14:14:32 -08:00
Ralph Giles
e7aa6cb9a0 Minor clarifications to the channel mapping section.
Mostly just being more verbose.
2013-01-11 17:11:07 -08:00
Ralph Giles
fc113b735b Use 'front center' in the channel mapping table.
This clarifies the meaning in surround configurations and better
distinguishes it from 'rear center'.
2013-01-11 17:01:38 -08:00
Ralph Giles
17d7fed1e0 Fix a typo. 2013-01-11 15:51:15 -08:00
Timothy B. Terriberry
4fec64651f Add HTTPS to make gmaxwell happy. 2013-01-10 19:29:17 -08:00
Timothy B. Terriberry
2d477a93c7 Flesh out the Implementation Status section a bit.
Add sections on VLC, foobar200, and Rockbox.
Be more complete about listing which features of the format are
 actually supported by each implementation.
Still need to do more testing for Chrome, FFmpeg, and libav.
2013-01-10 19:23:58 -08:00
Ralph Giles
a1b913f56d Clarify how grouped streams are not "Ogg Opus files".
We mean to make .opus only for degenerate--not concurrently
multiplexed or grouped--but optionally sequentially multiplexed
or chained physical Ogg streams.

However, we don't mean to say you can't use this draft with
such streams.

Also, replace the reference to RFC3534 with RFC5334, which
obsoletes the previous reference by defining video/ogg and
audio/ogg.
2013-01-10 17:00:18 -08:00
Ralph Giles
0c1487aed8 Add an 'Implementation Status' section to the Ogg Opus draft.
This is based on the experiment described in
http://tools.ietf.org/html/draft-sheffer-running-code-01

I've listed several major implementations. Their formatting
could probably be better. More obviously, this really demonstrates
the need for a good test suite to evaluate converage and compliance
with all these different implementations.
2013-01-10 16:38:31 -08:00
Ralph Giles
7ad2f43993 Trim an irrelevant clause.
This is true, but not important to understanding the limitation.
2013-01-10 14:15:41 -08:00
Jean-Marc Valin
8e183a32a4 RTP draft adopted as WG item 2013-01-10 09:47:26 -05:00
Jean-Marc Valin
ebdfbfb743 Fixes stupid preprocessor-related bug introduced in e368e6209.
Would cause the preemphasis and deemphasis to fail, but only with
custom modes enabled.
2013-01-09 11:13:00 -05:00
Jean-Marc Valin
fa28dea7be Fixes a seed issue introduced in 5367dac
Was causing the testvector to pass with lower quality, though
practically there was no quality degradation.
2013-01-03 21:15:16 -05:00
Jean-Marc Valin
e368e62092 Remove condition in pre/de-emphasis when not building with custom modes
Should slightly improve coverage and reduce code size
2013-01-03 14:28:28 -05:00
Ralph Giles
ba1bd031c7 Use AC_CONFIG_HEADERS.
This avoids a warning about obsolete AM_CONFIG_HEADERS() on more
recent autoconf. The new macro has been around at least since
autoconf 2.60. So this should be safe.
2013-01-02 15:29:26 -08:00
Jean-Marc Valin
5367dac3b0 seed and remaining_bits moved to band context 2012-12-22 21:56:22 -05:00
Jean-Marc Valin
a9d6286ca5 Using a band context to reduce the number of arguments being passed around. 2012-12-22 21:32:28 -05:00
Jean-Marc Valin
f18acee4a6 more bands.c cleaning up 2012-12-22 19:29:05 -05:00
Jean-Marc Valin
ddd0d21442 collapse mask cleanup 2012-12-22 19:29:01 -05:00
Jean-Marc Valin
414fd27056 Removes useless parameters and re-indents the code 2012-12-22 19:28:57 -05:00
Jean-Marc Valin
3d6c341867 Splitting off the recursion in quant_partition()
quant_band() now only handles the level0 case.
2012-12-22 19:28:53 -05:00
Jean-Marc Valin
4ffbf21174 stereo part of quant_band() moved to quant_band_stereo() 2012-12-22 19:28:47 -05:00
Jean-Marc Valin
113a5e1b1e Moves the split angle code to compute_theta() 2012-12-22 19:28:42 -05:00
Jean-Marc Valin
dfe3bf9650 First step in quant_band() cleanup: N=1 case. 2012-12-22 19:28:36 -05:00
Jean-Marc Valin
d683c76b88 Fixes MSVC warnings for double->float and float->int conversion 2012-12-21 16:17:38 -05:00
Ralph Giles
b5f739455d Add float literal suffixes to mlp_data.c.
Fixes an MSVC double truncation warning.
2012-12-21 12:06:24 -08:00
Ralph Giles
724385e242 Add float suffix to tansig_table literals.
This fixes a truncation warning in MSVC:

warning C4305: 'initializing' : truncation from 'double' to
'const opus_val16'.

opus_val16 is a float in the floating point build and an
int16 in the fixed-point build. The table isn't used in
the fixed-point build, but the compiler would presumedly
warn in that case as well.
2012-12-21 11:56:18 -08:00
Ralph Giles
0a29bb5155 Add tansig_table.h to the MSVC project files. 2012-12-21 11:49:46 -08:00
Jean-Marc Valin
3593bbf481 missing comment in win32/config.h 2012-12-21 14:11:10 -05:00
Jean-Marc Valin
23fcd706fb Only use automatic bandwidth detection when the user doesn't force bandwidth
Also fixes an issue with 40- and 60-ms frames using the repacketizer.
2012-12-21 13:09:43 -05:00
Jean-Marc Valin
2dd3fb9d59 Fixes bandwidth detection by not relying on uninitialized data 2012-12-21 12:28:25 -05:00
Jean-Marc Valin
5fb50adb7a skip bands with no energy 2012-12-21 11:52:03 -05:00
Jean-Marc Valin
b3eba24bab Capping lsb_depth to 16 unless using the float API of a float build 2012-12-21 11:51:59 -05:00
Jean-Marc Valin
7509fdb813 New bandwidth detection code
Can now work up to full-band and uses lsb_depth to fix the noise issue.
2012-12-21 11:51:45 -05:00
Jean-Marc Valin
56921ff73f Bump version number 2012-12-20 13:00:52 -05:00
Ralph Giles
05bf400a7a Update ogg draft based on comments from Tina le Grand.
http://www.ietf.org/mail-archive/web/codec/current/msg02951.html
2012-12-19 12:21:06 -08:00
Ralph Giles
c763a35e9c Update the oggopus script to use xml2rfc v2.
The command line has changed, for the better, but we need to
update the way we call it. Also adds an install hint if it's
not found on the path.

NB I tried to detect and fallback to the old syntax for the
version 1 (TCL) implementation but this is hard because it
doesn't support any switches (like --version) and it no
longer parses our remote entities.
2012-12-18 16:37:04 -08:00
Jean-Marc Valin
90bac9d148 Minor tuining of complexity thresholds 2012-12-14 14:01:06 -05:00
Jean-Marc Valin
28ef277db4 VBR code simplification 2012-12-14 13:21:09 -05:00
Jean-Marc Valin
dae16fb94b Cleanup: tf_estimate now ranges from 0 to 1 2012-12-13 21:40:58 -05:00
Jean-Marc Valin
f8809dda4b Dynalloc rate calibration 2012-12-12 15:30:26 -05:00
Jean-Marc Valin
1122d299ab Makes "stereo savings" less aggressive on mono or near-mono.
The max reduction now depends on intensity threshold too.
2012-12-12 15:30:23 -05:00
Jean-Marc Valin
b33db8f318 Makes tonality boost less aggressive
Some tests like Kamedo's HA test suggested that our tonal boost was a bit
too extreme.
2012-12-12 15:30:14 -05:00
Jean-Marc Valin
41fd7a12b5 Disables the new spread+tapset estimator 2012-12-12 14:41:29 -05:00
Ralph Giles
256c9595d8 Document that opus_packet_get_nb_frames, etc. can return OPUS_BAD_ARG.
NB they only check for len < 1, not for null data.
2012-12-11 10:17:11 -08:00
Timothy B. Terriberry
8eb9bb7939 Numerous PLC cleanups.
This should reduce computation, reduce stack usage, and be
 substantially easier to read, but should not change behavior.
It's not quite bit-exact because I collapsed the application of the
 decay and the fading into a single pass to save one multiply per
 sample, but the difference signal is silent.

It also changes the comments into complete sentences.
2012-12-07 14:07:22 -08:00
Ralph Giles
22d8dcf398 Remove the obsolete CELT_BUILD define from win32/config.h. 2012-12-07 09:16:34 -08:00
Gregory Maxwell
19239ea3a2 Add tests for GET_LAST_PACKET_DURATION.
Also remove a useless extern that crept into the tests from some
optimization driven testcase generation.
2012-12-05 21:50:08 -05:00
Jean-Marc Valin
a0737d1fcf Fixes OPUS_GET_LAST_PACKET_DURATION
Calling PLC/FEC with a different size was not updating it
2012-12-05 21:48:45 -05:00
Gregory Maxwell
535efb0707 Add missing packet_get_nb_samples test coverage and fix test output. 2012-12-05 19:27:12 -05:00
Ralph Giles
119d53c94d Bump soname version to match the 1.0.x branch.
Library soname versioning is something we normally change
only right before each release. However, with 1.0.2 being
released from the 1.0.x branch with 3.0.3, it makes sense
to make the same update here. That way when we do a new
release from master we can just increment again and have
the version properly reflect ranges relative to the stable
branch.
2012-12-05 15:57:45 -08:00