Fix msan uninitialized psEncCtrl->LTP_scale_Q14
Some checks are pending
Autotools / AutoMake/Linux/GCC (push) Waiting to run
Autotools / AutoMake/Linux/GCC/EnableDNN (push) Waiting to run
Autotools / AutoMake/Linux/GCC/EnableCustomModes (push) Waiting to run
Autotools / AutoMake/Linux/GCC/EnableAssertions (push) Waiting to run
CMake / Test build with CMake 3.16.0 (push) Waiting to run
CMake / CMake MINGW (push) Waiting to run
CMake / CMake/Linux/Lib/X64/Release (push) Waiting to run
CMake / CMake/MacOSX/Lib/X64/Release (push) Waiting to run
CMake / CMake/MacOSX/Framework/X64/Release (push) Waiting to run
CMake / CMake/Linux/So/X64/Release (push) Waiting to run
CMake / CMake/MacOSX/So/X64/Release (push) Waiting to run
CMake / CMake/Android/So/ARMv8/Release (push) Waiting to run
CMake / CMake/Android/Lib/ARMv8/Release (push) Waiting to run
CMake / CMake/Android/So/X86/Release (push) Waiting to run
CMake / CMake/Android/Lib/X86/Release (push) Waiting to run
CMake / CMake/Android/So/X64/Release (push) Waiting to run
CMake / CMake/Android/Lib/X64/Release (push) Waiting to run
CMake / CMake/AssertionsFuzz/Linux/Lib/X64/Release (push) Waiting to run
CMake / CMake/AssertionsFuzz/MacOSX/Lib/X64/Release (push) Waiting to run
CMake / CMake/CustomModes/Linux/Lib/X64/Release (push) Waiting to run
CMake / CMake/iOS/Framework/arm64/Release (push) Waiting to run
CMake / CMake/iOS/Dll/arm64/Release (push) Waiting to run
CMake / CMake/iOS/Lib/arm64/Release (push) Waiting to run
CMake / CMake/Windows/Dll/ARMv8/Release (push) Waiting to run
CMake / CMake/Windows/Lib/armv8/Release (push) Waiting to run
CMake / CMake/Windows/Dll/X64/Release (push) Waiting to run
CMake / CMake/Windows/Dll/X86/Release (push) Waiting to run
CMake / CMake/AssertionsFuzz/Windows/Lib/X64/Release (push) Waiting to run
CMake / CMake/Windows/Lib/X64/Release (push) Waiting to run
CMake / CMake/Windows/Lib/X86/Release (push) Waiting to run
DRED / CMake/Android/Lib/ARMv8/Release (push) Waiting to run
DRED / CMake/Android/Lib/X64/Release (push) Waiting to run
DRED / CMake/MacOSX/Lib/X64/Release (push) Waiting to run
DRED / CMake/Linux/Lib/X64/Release (push) Waiting to run
DRED / CMake/iOS/Lib/arm64/Release (push) Waiting to run
DRED / CMake/Windows/Lib/armv8/Release (push) Waiting to run
DRED / CMake/Windows/Lib/X64/Release (push) Waiting to run
DRED / AutoTools/Linux/Clang (push) Waiting to run
DRED / AutoTools/Linux/GCC (push) Waiting to run
Repository / Check trailing white spaces (push) Waiting to run

The value was never actually used (valgrind didn't complain) but msan
was complaining because it was passed as an argument.
This commit is contained in:
Jean-Marc Valin 2025-04-24 20:43:19 -04:00
parent 6a45b767e2
commit f37dcf5570
No known key found for this signature in database
GPG key ID: 8D2952BBB52C646D

View file

@ -118,6 +118,7 @@ void silk_find_pred_coefs_FIX(
silk_memset( psEncCtrl->LTPCoef_Q14, 0, psEnc->sCmn.nb_subfr * LTP_ORDER * sizeof( opus_int16 ) ); silk_memset( psEncCtrl->LTPCoef_Q14, 0, psEnc->sCmn.nb_subfr * LTP_ORDER * sizeof( opus_int16 ) );
psEncCtrl->LTPredCodGain_Q7 = 0; psEncCtrl->LTPredCodGain_Q7 = 0;
psEnc->sCmn.sum_log_gain_Q7 = 0; psEnc->sCmn.sum_log_gain_Q7 = 0;
psEncCtrl->LTP_scale_Q14 = 0;
} }
/* Limit on total predictive coding gain */ /* Limit on total predictive coding gain */