eden-emu/opus
15
0
Fork 0
mirror of https://github.com/xiph/opus.git synced 2025-06-07 16:00:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

optimisations: faster handling of the zero for compute_band_energies() and

Browse source 
normalise_bands(). Also, another bunch of restrict qualifiers -- mainly
to tell the compiler there's no aliasing between the array bounds and the
data.
This commit is contained in:
Jean-Marc Valin 2008-03-26 14:36:07 +11:00
parent 25aeed74f1
commit a56c34f381
2 changed files with 23 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

31
libcelt/bands.c
View file

@ -94,14 +94,14 @@ void compute_band_energies(const CELTMode *m, const celt_sig_t *X, celt_ener_t *
maxval = MAX32(maxval, ABS32(X[j*C+c])); maxval = MAX32(maxval, ABS32(X[j*C+c]));
if (maxval > 0) if (maxval > 0)
{ {
int shift = celt_zlog2(maxval)-10; int shift = celt_ilog2(maxval)-10;
for (j=B*eBands[i];j<B*eBands[i+1];j++) for (j=B*eBands[i];j<B*eBands[i+1];j++)
sum += VSHR32(X[j*C+c],shift)*VSHR32(X[j*C+c],shift); sum += VSHR32(X[j*C+c],shift)*VSHR32(X[j*C+c],shift);
/* We're adding one here to make damn sure we never end up with a pitch vector that's /* We're adding one here to make damn sure we never end up with a pitch vector that's
larger than unity norm */ larger than unity norm */
bank[i*C+c] = 1+VSHR32(EXTEND32(celt_sqrt(sum)),-shift); bank[i*C+c] = EPSILON+VSHR32(EXTEND32(celt_sqrt(sum)),-shift);
} else { } else {
bank[i*C+c] = 0; bank[i*C+c] = EPSILON;
} }
/*printf ("%f ", bank[i*C+c]);*/ /*printf ("%f ", bank[i*C+c]);*/
} }
@ -110,7 +110,7 @@ void compute_band_energies(const CELTMode *m, const celt_sig_t *X, celt_ener_t *
} }
/* Normalise each band such that the energy is one. */ /* Normalise each band such that the energy is one. */
void normalise_bands(const CELTMode *m, const celt_sig_t *freq, celt_norm_t *X, const celt_ener_t *bank) void normalise_bands(const CELTMode *m, const celt_sig_t * restrict freq, celt_norm_t * restrict X, const celt_ener_t *bank)
{ {
int i, c, B, C; int i, c, B, C;
const celt_int16_t *eBands = m->eBands; const celt_int16_t *eBands = m->eBands;
@ -125,10 +125,7 @@ void normalise_bands(const CELTMode *m, const celt_sig_t *freq, celt_norm_t *X,
celt_word16_t E; celt_word16_t E;
shift = celt_zlog2(bank[i*C+c])-13; shift = celt_zlog2(bank[i*C+c])-13;
E = VSHR32(bank[i*C+c], shift); E = VSHR32(bank[i*C+c], shift);
if (E>0)
g = EXTRACT16(celt_rcp(SHR32(MULT16_16(E,sqrtC_1[C-1]),11))); g = EXTRACT16(celt_rcp(SHR32(MULT16_16(E,sqrtC_1[C-1]),11)));
else
g = 0;
for (j=B*eBands[i];j<B*eBands[i+1];j++) for (j=B*eBands[i];j<B*eBands[i+1];j++)
X[j*C+c] = MULT16_16_Q14(VSHR32(freq[j*C+c],shift),g); X[j*C+c] = MULT16_16_Q14(VSHR32(freq[j*C+c],shift),g);
} }
@ -137,7 +134,7 @@ void normalise_bands(const CELTMode *m, const celt_sig_t *freq, celt_norm_t *X,
X[i] = 0; X[i] = 0;
} }
void renormalise_bands(const CELTMode *m, celt_norm_t *X) void renormalise_bands(const CELTMode *m, celt_norm_t * restrict X)
{ {
int i; int i;
VARDECL(celt_ener_t, tmpE); VARDECL(celt_ener_t, tmpE);
@ -175,7 +172,7 @@ void compute_band_energies(const CELTMode *m, const celt_sig_t *X, celt_ener_t *
} }
/* Normalise each band such that the energy is one. */ /* Normalise each band such that the energy is one. */
void normalise_bands(const CELTMode *m, const celt_sig_t *freq, celt_norm_t *X, const celt_ener_t *bank) void normalise_bands(const CELTMode *m, const celt_sig_t * restrict freq, celt_norm_t * restrict X, const celt_ener_t *bank)
{ {
int i, c, B, C; int i, c, B, C;
const celt_int16_t *eBands = m->eBands; const celt_int16_t *eBands = m->eBands;
@ -195,7 +192,7 @@ void normalise_bands(const CELTMode *m, const celt_sig_t *freq, celt_norm_t *X,
X[i] = 0; X[i] = 0;
} }
void renormalise_bands(const CELTMode *m, celt_norm_t *X) void renormalise_bands(const CELTMode *m, celt_norm_t * restrict X)
{ {
VARDECL(celt_ener_t, tmpE); VARDECL(celt_ener_t, tmpE);
SAVE_STACK; SAVE_STACK;
@ -207,7 +204,7 @@ void renormalise_bands(const CELTMode *m, celt_norm_t *X)
#endif #endif
/* De-normalise the energy to produce the synthesis from the unit-energy bands */ /* De-normalise the energy to produce the synthesis from the unit-energy bands */
void denormalise_bands(const CELTMode *m, const celt_norm_t *X, celt_sig_t *freq, const celt_ener_t *bank) void denormalise_bands(const CELTMode *m, const celt_norm_t * restrict X, celt_sig_t * restrict freq, const celt_ener_t *bank)
{ {
int i, c, B, C; int i, c, B, C;
const celt_int16_t *eBands = m->eBands; const celt_int16_t *eBands = m->eBands;
@ -291,16 +288,18 @@ void quant_bands(const CELTMode *m, celt_norm_t * restrict X, celt_norm_t *P, ce
{ {
int i, j, B, bits; int i, j, B, bits;
const celt_int16_t *eBands = m->eBands; const celt_int16_t *eBands = m->eBands;
VARDECL(celt_norm_t, norm); celt_norm_t * restrict norm;
VARDECL(celt_norm_t, _norm);
VARDECL(int, pulses); VARDECL(int, pulses);
VARDECL(int, offsets); VARDECL(int, offsets);
SAVE_STACK; SAVE_STACK;
B = m->nbMdctBlocks*m->nbChannels; B = m->nbMdctBlocks*m->nbChannels;
ALLOC(norm, B*eBands[m->nbEBands+1], celt_norm_t); ALLOC(_norm, B*eBands[m->nbEBands+1], celt_norm_t);
ALLOC(pulses, m->nbEBands, int); ALLOC(pulses, m->nbEBands, int);
ALLOC(offsets, m->nbEBands, int); ALLOC(offsets, m->nbEBands, int);
norm = _norm;
for (i=0;i<m->nbEBands;i++) for (i=0;i<m->nbEBands;i++)
offsets[i] = 0; offsets[i] = 0;
@ -351,16 +350,18 @@ void unquant_bands(const CELTMode *m, celt_norm_t * restrict X, celt_norm_t *P,
{ {
int i, j, B, bits; int i, j, B, bits;
const celt_int16_t *eBands = m->eBands; const celt_int16_t *eBands = m->eBands;
VARDECL(celt_norm_t, norm); celt_norm_t * restrict norm;
VARDECL(celt_norm_t, _norm);
VARDECL(int, pulses); VARDECL(int, pulses);
VARDECL(int, offsets); VARDECL(int, offsets);
SAVE_STACK; SAVE_STACK;
B = m->nbMdctBlocks*m->nbChannels; B = m->nbMdctBlocks*m->nbChannels;
ALLOC(norm, B*eBands[m->nbEBands+1], celt_norm_t); ALLOC(_norm, B*eBands[m->nbEBands+1], celt_norm_t);
ALLOC(pulses, m->nbEBands, int); ALLOC(pulses, m->nbEBands, int);
ALLOC(offsets, m->nbEBands, int); ALLOC(offsets, m->nbEBands, int);
norm = _norm;
for (i=0;i<m->nbEBands;i++) for (i=0;i<m->nbEBands;i++)
offsets[i] = 0; offsets[i] = 0;

12
libcelt/bands.h
View file

@ -56,16 +56,16 @@ void compute_band_energies(const CELTMode *m, const celt_sig_t *X, celt_ener_t *
* @param X Spectrum (returned normalised) * @param X Spectrum (returned normalised)
* @param bands Square root of the energy for each band * @param bands Square root of the energy for each band
*/ */
void normalise_bands(const CELTMode *m, const celt_sig_t *freq, celt_norm_t *X, const celt_ener_t *bands); void normalise_bands(const CELTMode *m, const celt_sig_t * restrict freq, celt_norm_t * restrict X, const celt_ener_t *bands);
void renormalise_bands(const CELTMode *m, celt_norm_t *X); void renormalise_bands(const CELTMode *m, celt_norm_t * restrict X);
/** Denormalise each band of X to restore full amplitude /** Denormalise each band of X to restore full amplitude
* @param m Mode data * @param m Mode data
* @param X Spectrum (returned de-normalised) * @param X Spectrum (returned de-normalised)
* @param bands Square root of the energy for each band * @param bands Square root of the energy for each band
*/ */
void denormalise_bands(const CELTMode *m, const celt_norm_t *X, celt_sig_t *freq, const celt_ener_t *bands); void denormalise_bands(const CELTMode *m, const celt_norm_t * restrict X, celt_sig_t * restrict freq, const celt_ener_t *bands);
/** Compute the pitch predictor gain for each pitch band /** Compute the pitch predictor gain for each pitch band
* @param m Mode data * @param m Mode data
@ -76,7 +76,7 @@ void denormalise_bands(const CELTMode *m, const celt_norm_t *X, celt_sig_t *freq
*/ */
void compute_pitch_gain(const CELTMode *m, const celt_norm_t *X, const celt_norm_t *P, celt_pgain_t *gains); void compute_pitch_gain(const CELTMode *m, const celt_norm_t *X, const celt_norm_t *P, celt_pgain_t *gains);
void pitch_quant_bands(const CELTMode *m, celt_norm_t *P, const celt_pgain_t *gains); void pitch_quant_bands(const CELTMode *m, celt_norm_t * restrict P, const celt_pgain_t * restrict gains);
/** Quantisation/encoding of the residual spectrum /** Quantisation/encoding of the residual spectrum
* @param m Mode data * @param m Mode data
@ -86,7 +86,7 @@ void pitch_quant_bands(const CELTMode *m, celt_norm_t *P, const celt_pgain_t *ga
* @param total_bits Total number of bits that can be used for the frame (including the ones already spent) * @param total_bits Total number of bits that can be used for the frame (including the ones already spent)
* @param enc Entropy encoder * @param enc Entropy encoder
*/ */
void quant_bands(const CELTMode *m, celt_norm_t *X, celt_norm_t *P, celt_mask_t *W, int total_bits, ec_enc *enc); void quant_bands(const CELTMode *m, celt_norm_t * restrict X, celt_norm_t *P, celt_mask_t *W, int total_bits, ec_enc *enc);
/** Decoding of the residual spectrum /** Decoding of the residual spectrum
* @param m Mode data * @param m Mode data
@ -95,7 +95,7 @@ void quant_bands(const CELTMode *m, celt_norm_t *X, celt_norm_t *P, celt_mask_t
* @param total_bits Total number of bits that can be used for the frame (including the ones already spent) * @param total_bits Total number of bits that can be used for the frame (including the ones already spent)
* @param dec Entropy decoder * @param dec Entropy decoder
*/ */
void unquant_bands(const CELTMode *m, celt_norm_t *X, celt_norm_t *P, int total_bits, ec_dec *dec); void unquant_bands(const CELTMode *m, celt_norm_t * restrict X, celt_norm_t *P, int total_bits, ec_dec *dec);
void stereo_mix(const CELTMode *m, celt_norm_t *X, const celt_ener_t *bank, int dir); void stereo_mix(const CELTMode *m, celt_norm_t *X, const celt_ener_t *bank, int dir);