From ed5c8d3d1e24d37a84a04148f52296d7243ac0ae Mon Sep 17 00:00:00 2001 From: Janos Follath Date: Mon, 15 Aug 2022 11:50:22 +0100 Subject: [PATCH] Bignum: make modulus value const The modulus value won't change during normal operations, make this clear in the struct and the function signatures. This won't prevent the caller from modifying the passed buffer, but might give a hint and reinforces the message of the documentation. Signed-off-by: Janos Follath --- library/bignum_mod.c | 2 +- library/bignum_mod.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/library/bignum_mod.c b/library/bignum_mod.c index dfccaf485..4382bf85a 100644 --- a/library/bignum_mod.c +++ b/library/bignum_mod.c @@ -102,7 +102,7 @@ void mbedtls_mpi_mod_modulus_free( mbedtls_mpi_mod_modulus *m ) } int mbedtls_mpi_mod_modulus_setup( mbedtls_mpi_mod_modulus *m, - mbedtls_mpi_uint *p, + const mbedtls_mpi_uint *p, size_t pn, mbedtls_mpi_mod_ext_rep ext_rep, mbedtls_mpi_mod_rep_selector int_rep ) diff --git a/library/bignum_mod.h b/library/bignum_mod.h index 3712af0f4..d2ba73ecd 100644 --- a/library/bignum_mod.h +++ b/library/bignum_mod.h @@ -53,7 +53,7 @@ typedef void *mbedtls_mpi_mont_struct; typedef void *mbedtls_mpi_opt_red_struct; typedef struct { - mbedtls_mpi_uint *p; + const mbedtls_mpi_uint *p; size_t limbs; // number of limbs size_t bits; // bitlen of p mbedtls_mpi_mod_ext_rep ext_rep; // signals external representation (eg. byte order) @@ -122,7 +122,7 @@ void mbedtls_mpi_mod_modulus_init( mbedtls_mpi_mod_modulus *m ); * invalid. */ int mbedtls_mpi_mod_modulus_setup( mbedtls_mpi_mod_modulus *m, - mbedtls_mpi_uint *p, + const mbedtls_mpi_uint *p, size_t pn, mbedtls_mpi_mod_ext_rep ext_rep, mbedtls_mpi_mod_rep_selector int_rep );