Add git rev-parse options

Signed-off-by: Xiaofei Bai <xiaofei.bai@arm.com>
This commit is contained in:
Xiaofei Bai 2021-11-03 07:12:31 +00:00
parent 184e8b6a36
commit ccd738b853

View file

@ -58,8 +58,8 @@ class CodeSizeComparison:
@staticmethod @staticmethod
def validate_revision(revision): def validate_revision(revision):
result = subprocess.run(["git", "rev-parse", "--verify", revision], result = subprocess.check_output(["git", "rev-parse", "--verify",
check=False, stdout=subprocess.PIPE) revision + "^{commit}"], shell=False)
return result return result
def _create_git_worktree(self, revision): def _create_git_worktree(self, revision):
@ -208,15 +208,11 @@ def main():
parser.exit() parser.exit()
validate_res = CodeSizeComparison.validate_revision(comp_args.old_rev) validate_res = CodeSizeComparison.validate_revision(comp_args.old_rev)
if validate_res.returncode != 0: old_revision = validate_res.decode().replace("\n", "")
sys.exit(validate_res.returncode)
old_revision = validate_res.stdout.decode().replace("\n", "")
if comp_args.new_rev is not None: if comp_args.new_rev is not None:
validate_res = CodeSizeComparison.validate_revision(comp_args.new_rev) validate_res = CodeSizeComparison.validate_revision(comp_args.new_rev)
if validate_res.returncode != 0: new_revision = validate_res.decode().replace("\n", "")
sys.exit(validate_res.returncode)
new_revision = validate_res.stdout.decode().replace("\n", "")
else: else:
new_revision = "current" new_revision = "current"