From b603bd34bc370d9a32c6762cfb067e7918bd0146 Mon Sep 17 00:00:00 2001 From: Hanno Becker Date: Wed, 10 Jul 2019 09:45:44 +0100 Subject: [PATCH] Remove assertion in mbedtls_ssl_decrypt_buf() mbedtls_ssl_decrypt_buf() asserts that the passed transform is not NULL, but the function is only invoked in a single place, and this invocation is clearly visible to be within a branch ensuring that the incoming transform isn't NULL. Remove the assertion for the benefit of code-size. --- library/ssl_tls.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/library/ssl_tls.c b/library/ssl_tls.c index ab33d8bf7..5f27e2da6 100644 --- a/library/ssl_tls.c +++ b/library/ssl_tls.c @@ -2368,11 +2368,6 @@ int mbedtls_ssl_decrypt_buf( mbedtls_ssl_context *ssl, #endif MBEDTLS_SSL_DEBUG_MSG( 2, ( "=> decrypt buf" ) ); - if( transform == NULL ) - { - MBEDTLS_SSL_DEBUG_MSG( 1, ( "no transform provided to decrypt_buf" ) ); - return( MBEDTLS_ERR_SSL_INTERNAL_ERROR ); - } if( rec == NULL || rec->buf == NULL || rec->buf_len < rec->data_offset ||