eden-emu/mbedtls
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Unify equality checker functions return value

Browse source 
The equality checker functions always return 0 or 1 value,
thus the type of return value can be the same dispite of the
size of the parameters.

Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>
This commit is contained in:
gabor-mezei-arm 2021-08-11 17:28:49 +02:00
parent 9cb55698aa
commit b11a56e34c
No known key found for this signature in database
GPG key ID: 106F5A41ECC305BD
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
library/constant_time.c
View file

@ -168,8 +168,8 @@ size_t mbedtls_cf_size_mask_ge( size_t x,
* This function is implemented without using comparison operators, as those * This function is implemented without using comparison operators, as those
* might be translated to branches by some compilers on some platforms. * might be translated to branches by some compilers on some platforms.
*/ */
size_t mbedtls_cf_size_bool_eq( size_t x, unsigned mbedtls_cf_size_bool_eq( size_t x,
size_t y ) size_t y )
{ {
/* diff = 0 if x == y, non-zero otherwise */ /* diff = 0 if x == y, non-zero otherwise */
const size_t diff = x ^ y; const size_t diff = x ^ y;
@ -189,7 +189,7 @@ size_t mbedtls_cf_size_bool_eq( size_t x,
#endif #endif
/* diff1 = (x != y) ? 1 : 0 */ /* diff1 = (x != y) ? 1 : 0 */
const size_t diff1 = diff_msb >> ( sizeof( diff_msb ) * 8 - 1 ); const unsigned diff1 = diff_msb >> ( sizeof( diff_msb ) * 8 - 1 );
return( 1 ^ diff1 ); return( 1 ^ diff1 );
} }

4
library/constant_time.h
View file

@ -50,8 +50,8 @@ size_t mbedtls_cf_size_mask_lt( size_t x,
size_t mbedtls_cf_size_mask_ge( size_t x, size_t mbedtls_cf_size_mask_ge( size_t x,
size_t y ); size_t y );
size_t mbedtls_cf_size_bool_eq( size_t x, unsigned mbedtls_cf_size_bool_eq( size_t x,
size_t y ); size_t y );
unsigned mbedtls_cf_size_gt( size_t x, unsigned mbedtls_cf_size_gt( size_t x,
size_t y ); size_t y );