eden-emu/mbedtls
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

code_size_compare: remove column of percentage for code size change

Browse source 
Percentage is not a useful number when looking at code size changes.
Since it depends on the base of the code size. It might give
misleading information by simply looking at the numbers.

Signed-off-by: Yanray Wang <yanray.wang@arm.com>
This commit is contained in:
Yanray Wang 2023-07-27 10:15:13 +08:00
parent ca9a3cbc1d
commit 6f09267646
1 changed files with 8 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

23
scripts/code_size_compare.py
View file

@ -594,7 +594,7 @@ class CodeSizeGeneratorWithSize(CodeSizeGenerator):
"""Write comparison result into a file. """Write comparison result into a file.
Writing Format: file_name current(text,data) old(text,data)\ Writing Format: file_name current(text,data) old(text,data)\
change(text,data) change_pct%(text,data) change(text,data)
""" """
def cal_size_section_variation(mod, fname, size_entry, attr): def cal_size_section_variation(mod, fname, size_entry, attr):
@ -603,26 +603,22 @@ class CodeSizeGeneratorWithSize(CodeSizeGenerator):
if fname in self.code_size[old_rev][mod]: if fname in self.code_size[old_rev][mod]:
old_size = int(self.code_size[old_rev][mod][fname].__dict__[attr]) old_size = int(self.code_size[old_rev][mod][fname].__dict__[attr])
change = new_size - old_size change = new_size - old_size
if old_size != 0: return [new_size, old_size, change]
change_pct = change / old_size
else:
change_pct = 0
return [new_size, old_size, change, change_pct]
else: else:
return [new_size] return [new_size]
if with_markdown: if with_markdown:
format_string = "| {:<30} | {:<18} | {:<14} | {:<17} | {:<18} |\n" format_string = "| {:<30} | {:<18} | {:<14} | {:<17} |\n"
else: else:
format_string = "{:<30} {:<18} {:<14} {:<17} {:<18}\n" format_string = "{:<30} {:<18} {:<14} {:<17}\n"
output.write(format_string output.write(format_string
.format("filename", .format("filename",
"current(text,data)", "old(text,data)", "current(text,data)", "old(text,data)",
"change(text,data)", "change%(text,data)")) "change(text,data)"))
if with_markdown: if with_markdown:
output.write(format_string output.write(format_string
.format(":----", "----:", "----:", "----:", "----:")) .format(":----", "----:", "----:", "----:"))
for mod, fname, size_entry in \ for mod, fname, size_entry in \
self._size_reader_helper(new_rev, output, with_markdown): self._size_reader_helper(new_rev, output, with_markdown):
@ -644,17 +640,14 @@ class CodeSizeGeneratorWithSize(CodeSizeGenerator):
# old(text,data) # old(text,data)
str(text_vari[1]) + "," + str(data_vari[1]), str(text_vari[1]) + "," + str(data_vari[1]),
# change(text,data) # change(text,data)
str(text_vari[2]) + "," + str(data_vari[2]), str(text_vari[2]) + "," + str(data_vari[2])))
# change%(text,data)
"{:.0%}".format(text_vari[3]) + ","
+ "{:.0%}".format(data_vari[3])))
else: else:
output.write( output.write(
format_string format_string
.format(fname, .format(fname,
# current(text,data) # current(text,data)
str(text_vari[0]) + "," + str(data_vari[0]), str(text_vari[0]) + "," + str(data_vari[0]),
'None', 'None', 'None')) 'None', 'None'))
class CodeSizeComparison: class CodeSizeComparison: