From 578664601e0b0ac7d74099270f88ea03e7be547e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Manuel=20P=C3=A9gouri=C3=A9-Gonnard?= Date: Tue, 6 Dec 2022 12:14:49 +0100 Subject: [PATCH] Fix missing dependency declaration in test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit muladd() (restartable or not) is only available when at least one short weirstrass curve is enabled. Found by depends.py curves (now that restartable is part of full). Also, document that restartable only work for short weierstrass curves (actually unrelated, but this made me think of that). Signed-off-by: Manuel Pégourié-Gonnard --- include/mbedtls/mbedtls_config.h | 2 ++ tests/suites/test_suite_ecp.function | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/mbedtls/mbedtls_config.h b/include/mbedtls/mbedtls_config.h index 7a681d1f2..921a74918 100644 --- a/include/mbedtls/mbedtls_config.h +++ b/include/mbedtls/mbedtls_config.h @@ -721,6 +721,8 @@ * elliptic curve functionality. It is incompatible with * MBEDTLS_ECP_ALT, MBEDTLS_ECDH_XXX_ALT, MBEDTLS_ECDSA_XXX_ALT. * + * \note This option only works for Short Weierstrass curves. + * * Uncomment this macro to enable restartable ECC computations. */ //#define MBEDTLS_ECP_RESTARTABLE diff --git a/tests/suites/test_suite_ecp.function b/tests/suites/test_suite_ecp.function index 7d29e525e..2971c576c 100644 --- a/tests/suites/test_suite_ecp.function +++ b/tests/suites/test_suite_ecp.function @@ -237,7 +237,7 @@ exit: } /* END_CASE */ -/* BEGIN_CASE depends_on:MBEDTLS_ECP_RESTARTABLE */ +/* BEGIN_CASE depends_on:MBEDTLS_ECP_RESTARTABLE:MBEDTLS_ECP_SHORT_WEIERSTRASS_ENABLED */ void ecp_muladd_restart( int id, char *xR_str, char *yR_str, char *u1_str, char *u2_str, char *xQ_str, char *yQ_str,