eden-emu/mbedtls
19
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Apply suggestions from code review

Browse source 
Co-authored-by: Tom Cosgrove <tom.cosgrove@arm.com>
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
This commit is contained in:
Dave Rodgman 2023-03-10 17:05:54 +00:00
parent d12b592bc1
commit 3fe2abf306
3 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
ChangeLog.d/pkcs7-parser.txt
View file

@ -1,15 +1,15 @@
Features Features
* Added partial support for parsing the PKCS #7 cryptographic message * Added partial support for parsing the PKCS #7 Cryptographic Message
syntax, as defined in RFC 2315. Currently, support is limited to the Syntax, as defined in RFC 2315. Currently, support is limited to the
following: following:
- Only the signed data content type, version 1 is supported. - Only the signed-data content type, version 1 is supported.
- Only DER encoding is supported. - Only DER encoding is supported.
- Only a single digest algorithm per message is supported. - Only a single digest algorithm per message is supported.
- Only 0 or 1 certificates are supported per message, which must be in - Only 0 or 1 certificates are supported per message, which must be in
X.509 format. X.509 format.
- There is no support for certificate-revocation lists. - There is no support for certificate revocation lists.
- The authenticated and unauthenticated attribute fields of SignerInfo - The authenticated and unauthenticated attribute fields of SignerInfo
must be empty. must be empty.
Many thanks to Daniel Axtens, Nayna Jain, and Nick Child from IBM for Many thanks to Daniel Axtens, Nayna Jain, and Nick Child from IBM for
contributing this feature. Thanks to Demi-Marie Obenour for contributing contributing this feature. Thanks to Demi-Marie Obenour for contributing
various improvements, tests and bug-fixes. various improvements, tests and bug fixes.

2
include/mbedtls/mbedtls_config.h
View file

@ -2862,7 +2862,7 @@
/** /**
* \def MBEDTLS_PKCS7_C * \def MBEDTLS_PKCS7_C
* *
* Enable PKCS7 core for using PKCS7 formatted signatures. * Enable PKCS #7 core for using PKCS #7-formatted signatures.
* RFC Link - https://tools.ietf.org/html/rfc2315 * RFC Link - https://tools.ietf.org/html/rfc2315
* *
* Module: library/pkcs7.c * Module: library/pkcs7.c

4
include/mbedtls/pkcs7.h
View file

@ -22,8 +22,8 @@
*/ */
/** /**
* Note: For the time being, this implementation of the PKCS #7 cryptographic * Note: For the time being, this implementation of the PKCS #7 Cryptographic
* message syntax is a partial implementation of RFC 2315. * Message Syntax is a partial implementation of RFC 2315.
* Differences include: * Differences include:
* - The RFC specifies 6 different content types. The only type currently * - The RFC specifies 6 different content types. The only type currently
* supported in Mbed TLS is the signed data content type. * supported in Mbed TLS is the signed data content type.