eden-emu/mbedtls
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ASN.1 write tests: test with larger buffer

Browse source 
Test with the output buffer size up to *and including* the expected output
size plus one. `... < expected->len + 1` was evidently a mistake.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This commit is contained in:
Gilles Peskine 2022-06-10 20:15:44 +02:00
parent 321a08944b
commit 2c2730a372
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
tests/suites/test_suite_asn1write.function
View file

@ -63,7 +63,7 @@ void mbedtls_asn1_write_null( data_t *expected )
generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 }; generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 };
int ret; int ret;
for( data.size = 0; data.size < expected->len + 1; data.size++ ) for( data.size = 0; data.size <= expected->len + 1; data.size++ )
{ {
if( ! generic_write_start_step( &data ) ) if( ! generic_write_start_step( &data ) )
goto exit; goto exit;
@ -83,7 +83,7 @@ void mbedtls_asn1_write_bool( int val, data_t *expected )
generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 }; generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 };
int ret; int ret;
for( data.size = 0; data.size < expected->len + 1; data.size++ ) for( data.size = 0; data.size <= expected->len + 1; data.size++ )
{ {
if( ! generic_write_start_step( &data ) ) if( ! generic_write_start_step( &data ) )
goto exit; goto exit;
@ -103,7 +103,7 @@ void mbedtls_asn1_write_int( int val, data_t *expected )
generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 }; generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 };
int ret; int ret;
for( data.size = 0; data.size < expected->len + 1; data.size++ ) for( data.size = 0; data.size <= expected->len + 1; data.size++ )
{ {
if( ! generic_write_start_step( &data ) ) if( ! generic_write_start_step( &data ) )
goto exit; goto exit;
@ -124,7 +124,7 @@ void mbedtls_asn1_write_enum( int val, data_t *expected )
generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 }; generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 };
int ret; int ret;
for( data.size = 0; data.size < expected->len + 1; data.size++ ) for( data.size = 0; data.size <= expected->len + 1; data.size++ )
{ {
if( ! generic_write_start_step( &data ) ) if( ! generic_write_start_step( &data ) )
goto exit; goto exit;
@ -148,7 +148,7 @@ void mbedtls_asn1_write_mpi( data_t *val, data_t *expected )
mbedtls_mpi_init( &mpi ); mbedtls_mpi_init( &mpi );
TEST_ASSERT( mbedtls_mpi_read_binary( &mpi, val->x, val->len ) == 0 ); TEST_ASSERT( mbedtls_mpi_read_binary( &mpi, val->x, val->len ) == 0 );
for( data.size = 0; data.size < expected->len + 1; data.size++ ) for( data.size = 0; data.size <= expected->len + 1; data.size++ )
{ {
if( ! generic_write_start_step( &data ) ) if( ! generic_write_start_step( &data ) )
goto exit; goto exit;
@ -171,7 +171,7 @@ void mbedtls_asn1_write_string( int tag, data_t *content, data_t *expected )
generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 }; generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 };
int ret; int ret;
for( data.size = 0; data.size < expected->len + 1; data.size++ ) for( data.size = 0; data.size <= expected->len + 1; data.size++ )
{ {
if( ! generic_write_start_step( &data ) ) if( ! generic_write_start_step( &data ) )
goto exit; goto exit;
@ -225,7 +225,7 @@ void mbedtls_asn1_write_algorithm_identifier( data_t *oid,
generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 }; generic_write_data_t data = { NULL, NULL, NULL, NULL, 0 };
int ret; int ret;
for( data.size = 0; data.size < expected->len + 1; data.size++ ) for( data.size = 0; data.size <= expected->len + 1; data.size++ )
{ {
if( ! generic_write_start_step( &data ) ) if( ! generic_write_start_step( &data ) )
goto exit; goto exit;
@ -309,7 +309,7 @@ void test_asn1_write_bitstrings( data_t *bitstring, int bits,
( is_named ? mbedtls_asn1_write_named_bitstring : ( is_named ? mbedtls_asn1_write_named_bitstring :
mbedtls_asn1_write_bitstring ); mbedtls_asn1_write_bitstring );
for( data.size = 0; data.size < expected->len + 1; data.size++ ) for( data.size = 0; data.size <= expected->len + 1; data.size++ )
{ {
if( ! generic_write_start_step( &data ) ) if( ! generic_write_start_step( &data ) )
goto exit; goto exit;