Windows: Address MSVC Level 4 & WDK's OACR/Prefast warnings

* The library is now compiled with warning level 4 for VS2010
* Move silencing of 4200, 28125 and 28719 to msvc/config.h
* Add fixes in core to silence unused variables warnings
* Ensure that spinlock is always set interlocked in poll_windows
* Add missing check for calloc return value
* Fix data assignation in conditionals warnings
* Fix an OACR/Prefast error related to the use of strncpy in xusb.c
* Also fixes whitespace inconsistencies in core
* Issues reported by Orin Eman and Xiaofan Chen. See:
  https://sourceforge.net/mailarchive/message.php?msg_id=29412656
This commit is contained in:
Pete Batard 2012-06-25 19:13:42 +01:00
parent 89b43a6929
commit 0e0cbb6c27
10 changed files with 57 additions and 40 deletions

View file

@ -935,7 +935,10 @@ int main(int argc, char** argv)
break;
case 'b':
if (j+1 < argc) {
strncpy(binary_name, argv[j+1], 64);
// WDK's OACR doesn't like strncpy...
for (i=0; (i<(sizeof(binary_name)-1)) && (argv[j+1][i] != 0); i++)
binary_name[i] = argv[j+1][i];
binary_name[i] = 0;
j++;
}
binary_dump = true;