service: nfp: address comments
This commit is contained in:
parent
28792b26a5
commit
d389a05005
9 changed files with 29 additions and 26 deletions
|
@ -20,7 +20,7 @@ constexpr PadIdentifier identifier = {
|
|||
|
||||
VirtualAmiibo::VirtualAmiibo(std::string input_engine_) : InputEngine(std::move(input_engine_)) {}
|
||||
|
||||
VirtualAmiibo::~VirtualAmiibo() {}
|
||||
VirtualAmiibo::~VirtualAmiibo() = default;
|
||||
|
||||
Common::Input::PollingError VirtualAmiibo::SetPollingMode(
|
||||
[[maybe_unused]] const PadIdentifier& identifier_,
|
||||
|
@ -41,7 +41,7 @@ Common::Input::PollingError VirtualAmiibo::SetPollingMode(
|
|||
}
|
||||
|
||||
Common::Input::NfcState VirtualAmiibo::SupportsNfc(
|
||||
[[maybe_unused]] const PadIdentifier& identifier_) {
|
||||
[[maybe_unused]] const PadIdentifier& identifier_) const {
|
||||
return Common::Input::NfcState::Success;
|
||||
}
|
||||
|
||||
|
|
|
@ -39,7 +39,7 @@ public:
|
|||
Common::Input::PollingError SetPollingMode(
|
||||
const PadIdentifier& identifier_, const Common::Input::PollingMode polling_mode_) override;
|
||||
|
||||
Common::Input::NfcState SupportsNfc(const PadIdentifier& identifier_) override;
|
||||
Common::Input::NfcState SupportsNfc(const PadIdentifier& identifier_) const override;
|
||||
|
||||
Common::Input::NfcState WriteNfcData(const PadIdentifier& identifier_,
|
||||
const std::vector<u8>& data) override;
|
||||
|
|
|
@ -129,7 +129,8 @@ public:
|
|||
}
|
||||
|
||||
// Request nfc data from a controller
|
||||
virtual Common::Input::NfcState SupportsNfc([[maybe_unused]] const PadIdentifier& identifier) {
|
||||
virtual Common::Input::NfcState SupportsNfc(
|
||||
[[maybe_unused]] const PadIdentifier& identifier) const {
|
||||
return Common::Input::NfcState::NotSupported;
|
||||
}
|
||||
|
||||
|
|
|
@ -768,7 +768,7 @@ public:
|
|||
return input_engine->SetCameraFormat(identifier, camera_format);
|
||||
}
|
||||
|
||||
Common::Input::NfcState SupportsNfc() override {
|
||||
Common::Input::NfcState SupportsNfc() const override {
|
||||
return input_engine->SupportsNfc(identifier);
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue