eden-emu/breakpad
17
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Breakpad: Avoid warnings building with G++ 4.4.1 using -O3 -Wall.

Browse source 
src/processor/minidump.cc:1067: warning: format ‘%llx’ expects type ‘long long unsigned int’, but argument 3 has type ‘unsigned int’
src/processor/stackwalker_arm.cc:83: warning: unused variable ‘last_frame’
src/processor/minidump_stackwalk.cc:163: warning: ‘trust_name’ may be used uninitialized in this function

a=jimblandy, r=ted.mielczarek


git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@481 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
jimblandy 2010-01-12 16:41:13 +00:00
parent e9faf54828
commit 0441036f9e
3 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/processor/minidump.cc
View file

@ -1063,7 +1063,7 @@ void MinidumpContext::Print() {
for (unsigned int fpe_index = 0; for (unsigned int fpe_index = 0;
fpe_index < MD_FLOATINGSAVEAREA_ARM_FPEXTRA_COUNT; fpe_index < MD_FLOATINGSAVEAREA_ARM_FPEXTRA_COUNT;
++fpe_index) { ++fpe_index) {
printf(" float_save.extra[%2d] = 0x%" PRIx64 "\n", printf(" float_save.extra[%2d] = 0x%" PRIx32 "\n",
fpe_index, context_arm->float_save.extra[fpe_index]); fpe_index, context_arm->float_save.extra[fpe_index]);
} }

1
src/processor/minidump_stackwalk.cc
View file

@ -162,6 +162,7 @@ static void PrintStack(const CallStack *stack, const string &cpu) {
} }
const char *trust_name; const char *trust_name;
switch (frame_x86->trust) { switch (frame_x86->trust) {
default:
case StackFrameX86::FRAME_TRUST_NONE: case StackFrameX86::FRAME_TRUST_NONE:
trust_name = "unknown"; trust_name = "unknown";
break; break;

3
src/processor/stackwalker_arm.cc
View file

@ -80,9 +80,6 @@ StackFrame* StackwalkerARM::GetCallerFrame(
return NULL; return NULL;
} }
StackFrameARM *last_frame = static_cast<StackFrameARM*>(
stack->frames()->back());
// TODO: Can't actually walk the stack on ARM without the CFI data. // TODO: Can't actually walk the stack on ARM without the CFI data.
// Implement this when the CFI symbol dumper changes have landed. // Implement this when the CFI symbol dumper changes have landed.
return NULL; return NULL;