From 89fda4557228aa75327e13855da78ea317dc40c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Ferenc=20Nagy-Egri?= Date: Mon, 28 Oct 2024 14:48:35 +0100 Subject: [PATCH] scripts: Fix user self-hosting dependency in update_deps.py The documentation states that users can override where to take a dependency from via variables like VULKAN_HEADERS_INSTALL_DIR, however the helper.cmake written by the scripts/CMakeLists.txt FORCE updates the cache variable to the location inside known_good.json, practically overwriting the user-provided path given on the CLI using -D, also going into the cache. --- scripts/update_deps.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update_deps.py b/scripts/update_deps.py index 7165d9f..461e575 100755 --- a/scripts/update_deps.py +++ b/scripts/update_deps.py @@ -622,7 +622,7 @@ def CreateHelper(args, repos, filename): if repo.api is not None and repo.api != args.api: continue if install_names and repo.name in install_names and repo.on_build_platform: - helper_file.write('set({var} "{dir}" CACHE STRING "" FORCE)\n' + helper_file.write('set({var} "{dir}" CACHE STRING "")\n' .format( var=install_names[repo.name], dir=escape(repo.install_dir)))