eden-emu/Vulkan-Utility-Libraries
19
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix UBSAN error
Some checks failed
ci / build_and_test (Debug, macos-latest) (push) Has been cancelled
Details
ci / build_and_test (Debug, ubuntu-22.04) (push) Has been cancelled
Details
ci / build_and_test (Debug, ubuntu-24.04) (push) Has been cancelled
Details
ci / build_and_test (Debug, windows-latest) (push) Has been cancelled
Details
ci / build_and_test (Release, macos-latest) (push) Has been cancelled
Details
ci / build_and_test (Release, ubuntu-22.04) (push) Has been cancelled
Details
ci / build_and_test (Release, ubuntu-24.04) (push) Has been cancelled
Details
ci / build_and_test (Release, windows-latest) (push) Has been cancelled
Details
ci / windows-arm64 (push) Has been cancelled
Details
ci / android (arm64-v8a) (push) Has been cancelled
Details
ci / android (armeabi-v7a) (push) Has been cancelled
Details
ci / reuse (push) Has been cancelled
Details
ci / chromium (push) Has been cancelled
Details
ci / generate_source (push) Has been cancelled
Details
format / clang-format (push) Has been cancelled
Details

Browse source 
Calling memcpy with either src or dst as nullptr is undefined
even if the count is 0.

Discovered by running tests with -fsanitize=undefined

safe_struct.extension_add_remove specifcially
This commit is contained in:
jpr42 2025-04-11 23:20:56 -07:00 • committed by Charles Giessen
parent ad2ffcba7b
commit 4ee0833a3c
2 changed files with 19 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
include/vulkan/utility/vk_safe_struct_utils.hpp
View file

@ -83,7 +83,9 @@ bool AddExtension(CreateInfo& ci, const char* extension_name) {
return false;
}
char** exts = new char*[ci.enabledExtensionCount + 1];
memcpy(exts, ci.ppEnabledExtensionNames, sizeof(char*) * ci.enabledExtensionCount);
if (ci.ppEnabledExtensionNames) {
memcpy(exts, ci.ppEnabledExtensionNames, sizeof(char*) * ci.enabledExtensionCount);
}
exts[ci.enabledExtensionCount] = SafeStringCopy(extension_name);
delete[] ci.ppEnabledExtensionNames;
ci.ppEnabledExtensionNames = exts;