From def7a43a2eaeae2c56e41181ad6b075e189d3740 Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Mon, 24 Jun 2024 19:32:11 -0700 Subject: [PATCH] SDL_HINT_IME_SHOW_UI defaults to SDL_TRUE This hint is currently only used on Windows, and this matches the behavior of other platforms. --- include/SDL3/SDL_hints.h | 4 ++-- src/video/windows/SDL_windowskeyboard.c | 2 +- test/checkkeys.c | 3 --- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/include/SDL3/SDL_hints.h b/include/SDL3/SDL_hints.h index c28fc5df5..3a5e02637 100644 --- a/include/SDL3/SDL_hints.h +++ b/include/SDL3/SDL_hints.h @@ -966,8 +966,8 @@ extern "C" { * * The variable can be set to the following values: * - * - "0": Native UI components are not display. (default) - * - "1": Native UI components are displayed. + * - "0": Native UI components are not display. + * - "1": Native UI components are displayed. (default) * * This hint should be set before SDL is initialized. * diff --git a/src/video/windows/SDL_windowskeyboard.c b/src/video/windows/SDL_windowskeyboard.c index 2863fd6d4..cbb29a3d8 100644 --- a/src/video/windows/SDL_windowskeyboard.c +++ b/src/video/windows/SDL_windowskeyboard.c @@ -365,7 +365,7 @@ static void UILess_DisableUIUpdates(SDL_VideoData *videodata); static SDL_bool WIN_ShouldShowNativeUI() { - return SDL_GetHintBoolean(SDL_HINT_IME_SHOW_UI, SDL_FALSE); + return SDL_GetHintBoolean(SDL_HINT_IME_SHOW_UI, SDL_TRUE); } static int IME_Init(SDL_VideoData *videodata, HWND hwnd) diff --git a/test/checkkeys.c b/test/checkkeys.c index adaa1cb0f..052a7b98d 100644 --- a/test/checkkeys.c +++ b/test/checkkeys.c @@ -540,9 +540,6 @@ int main(int argc, char *argv[]) } #endif - /* Enable showing IME candidates */ - SDL_SetHint(SDL_HINT_IME_SHOW_UI, "1"); - for (i = 0; i < state->num_windows; ++i) { UpdateTextWindowInputRect(SDL_GetWindowID(state->windows[i]));