diff --git a/include/SDL3/SDL_render.h b/include/SDL3/SDL_render.h index b52087e713..e2bf9e317b 100644 --- a/include/SDL3/SDL_render.h +++ b/include/SDL3/SDL_render.h @@ -79,7 +79,7 @@ typedef struct SDL_RendererInfo { const char *name; /**< The name of the renderer */ Uint32 flags; /**< Supported ::SDL_RendererFlags */ - Uint32 num_texture_formats; /**< The number of available texture formats */ + int num_texture_formats; /**< The number of available texture formats */ Uint32 texture_formats[16]; /**< The available texture formats */ int max_texture_width; /**< The maximum texture width */ int max_texture_height; /**< The maximum texture height */ diff --git a/include/SDL3/SDL_vulkan.h b/include/SDL3/SDL_vulkan.h index 98590786e5..58fe118836 100644 --- a/include/SDL3/SDL_vulkan.h +++ b/include/SDL3/SDL_vulkan.h @@ -141,7 +141,7 @@ extern DECLSPEC void SDLCALL SDL_Vulkan_UnloadLibrary(void); * This should be called after either calling SDL_Vulkan_LoadLibrary() or * creating an SDL_Window with the `SDL_WINDOW_VULKAN` flag. * - * On return, the variable pointed to by `pCount` will be set to the number of + * On return, the variable pointed to by `count` will be set to the number of * elements returned, suitable for using with * VkInstanceCreateInfo::enabledExtensionCount, and the returned array can be * used with VkInstanceCreateInfo::ppEnabledExtensionNames, for calling @@ -149,7 +149,7 @@ extern DECLSPEC void SDLCALL SDL_Vulkan_UnloadLibrary(void); * * You should not free the returned array; it is owned by SDL. * - * \param pCount A pointer to Uint32 that will be filled with the number of + * \param count A pointer to an int that will be filled with the number of * extensions returned. * \returns An array of extension name strings on success, NULL on error. * @@ -157,7 +157,7 @@ extern DECLSPEC void SDLCALL SDL_Vulkan_UnloadLibrary(void); * * \sa SDL_Vulkan_CreateSurface */ -extern DECLSPEC char const* const* SDLCALL SDL_Vulkan_GetInstanceExtensions(Uint32 *pCount); +extern DECLSPEC char const* const* SDLCALL SDL_Vulkan_GetInstanceExtensions(int *count); /** * Create a Vulkan rendering surface for a window. diff --git a/src/dynapi/SDL_dynapi_procs.h b/src/dynapi/SDL_dynapi_procs.h index b19f615cb8..cae0a6394a 100644 --- a/src/dynapi/SDL_dynapi_procs.h +++ b/src/dynapi/SDL_dynapi_procs.h @@ -688,7 +688,7 @@ SDL_DYNAPI_PROC(int,SDL_UpdateWindowSurface,(SDL_Window *a),(a),return) SDL_DYNAPI_PROC(int,SDL_UpdateWindowSurfaceRects,(SDL_Window *a, const SDL_Rect *b, int c),(a,b,c),return) SDL_DYNAPI_PROC(int,SDL_UpdateYUVTexture,(SDL_Texture *a, const SDL_Rect *b, const Uint8 *c, int d, const Uint8 *e, int f, const Uint8 *g, int h),(a,b,c,d,e,f,g,h),return) SDL_DYNAPI_PROC(SDL_bool,SDL_Vulkan_CreateSurface,(SDL_Window *a, VkInstance b, const struct VkAllocationCallbacks *c, VkSurfaceKHR *d),(a,b,c,d),return) -SDL_DYNAPI_PROC(char const* const*,SDL_Vulkan_GetInstanceExtensions,(Uint32 *a),(a),return) +SDL_DYNAPI_PROC(char const* const*,SDL_Vulkan_GetInstanceExtensions,(int *a),(a),return) SDL_DYNAPI_PROC(SDL_FunctionPointer,SDL_Vulkan_GetVkGetInstanceProcAddr,(void),(),return) SDL_DYNAPI_PROC(int,SDL_Vulkan_LoadLibrary,(const char *a),(a),return) SDL_DYNAPI_PROC(void,SDL_Vulkan_UnloadLibrary,(void),(),) diff --git a/src/render/SDL_render.c b/src/render/SDL_render.c index 72f23cd699..a6a785bbf7 100644 --- a/src/render/SDL_render.c +++ b/src/render/SDL_render.c @@ -1187,7 +1187,7 @@ static SDL_bool IsSupportedBlendMode(SDL_Renderer *renderer, SDL_BlendMode blend static SDL_bool IsSupportedFormat(SDL_Renderer *renderer, Uint32 format) { - Uint32 i; + int i; for (i = 0; i < renderer->info.num_texture_formats; ++i) { if (renderer->info.texture_formats[i] == format) { @@ -1199,7 +1199,7 @@ static SDL_bool IsSupportedFormat(SDL_Renderer *renderer, Uint32 format) static Uint32 GetClosestSupportedFormat(SDL_Renderer *renderer, Uint32 format) { - Uint32 i; + int i; if (SDL_ISPIXELFORMAT_FOURCC(format)) { /* Look for an exact match */ @@ -1438,14 +1438,14 @@ SDL_Texture *SDL_CreateTextureFromSurface(SDL_Renderer *renderer, SDL_Surface *s /* No alpha, but a colorkey => promote to alpha */ if (!fmt->Amask && SDL_SurfaceHasColorKey(surface)) { if (fmt->format == SDL_PIXELFORMAT_XRGB8888) { - for (i = 0; i < (int)renderer->info.num_texture_formats; ++i) { + for (i = 0; i < renderer->info.num_texture_formats; ++i) { if (renderer->info.texture_formats[i] == SDL_PIXELFORMAT_ARGB8888) { format = SDL_PIXELFORMAT_ARGB8888; break; } } } else if (fmt->format == SDL_PIXELFORMAT_XBGR8888) { - for (i = 0; i < (int)renderer->info.num_texture_formats; ++i) { + for (i = 0; i < renderer->info.num_texture_formats; ++i) { if (renderer->info.texture_formats[i] == SDL_PIXELFORMAT_ABGR8888) { format = SDL_PIXELFORMAT_ABGR8888; break; @@ -1454,7 +1454,7 @@ SDL_Texture *SDL_CreateTextureFromSurface(SDL_Renderer *renderer, SDL_Surface *s } } else { /* Exact match would be fine */ - for (i = 0; i < (int)renderer->info.num_texture_formats; ++i) { + for (i = 0; i < renderer->info.num_texture_formats; ++i) { if (renderer->info.texture_formats[i] == fmt->format) { format = fmt->format; break; @@ -1464,7 +1464,7 @@ SDL_Texture *SDL_CreateTextureFromSurface(SDL_Renderer *renderer, SDL_Surface *s /* Look for 10-bit pixel formats if needed */ if (format == SDL_PIXELFORMAT_UNKNOWN && SDL_ISPIXELFORMAT_10BIT(fmt->format)) { - for (i = 0; i < (int)renderer->info.num_texture_formats; ++i) { + for (i = 0; i < renderer->info.num_texture_formats; ++i) { if (SDL_ISPIXELFORMAT_10BIT(renderer->info.texture_formats[i])) { format = renderer->info.texture_formats[i]; break; @@ -1475,7 +1475,7 @@ SDL_Texture *SDL_CreateTextureFromSurface(SDL_Renderer *renderer, SDL_Surface *s /* Look for floating point pixel formats if needed */ if (format == SDL_PIXELFORMAT_UNKNOWN && (SDL_ISPIXELFORMAT_10BIT(fmt->format) || SDL_ISPIXELFORMAT_FLOAT(fmt->format))) { - for (i = 0; i < (int)renderer->info.num_texture_formats; ++i) { + for (i = 0; i < renderer->info.num_texture_formats; ++i) { if (SDL_ISPIXELFORMAT_FLOAT(renderer->info.texture_formats[i])) { format = renderer->info.texture_formats[i]; break; @@ -1486,7 +1486,7 @@ SDL_Texture *SDL_CreateTextureFromSurface(SDL_Renderer *renderer, SDL_Surface *s /* Fallback, choose a valid pixel format */ if (format == SDL_PIXELFORMAT_UNKNOWN) { format = renderer->info.texture_formats[0]; - for (i = 0; i < (int)renderer->info.num_texture_formats; ++i) { + for (i = 0; i < renderer->info.num_texture_formats; ++i) { if (!SDL_ISPIXELFORMAT_FOURCC(renderer->info.texture_formats[i]) && SDL_ISPIXELFORMAT_ALPHA(renderer->info.texture_formats[i]) == needAlpha) { format = renderer->info.texture_formats[i]; diff --git a/src/render/vulkan/SDL_render_vulkan.c b/src/render/vulkan/SDL_render_vulkan.c index 08b5c7dc6f..71545a7b21 100644 --- a/src/render/vulkan/SDL_render_vulkan.c +++ b/src/render/vulkan/SDL_render_vulkan.c @@ -1708,7 +1708,7 @@ static VkResult VULKAN_CreateDeviceResources(SDL_Renderer *renderer, SDL_Propert appInfo.apiVersion = VK_API_VERSION_1_0; instanceCreateInfo.sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO; instanceCreateInfo.pApplicationInfo = &appInfo; - char const *const *instanceExtensions = SDL_Vulkan_GetInstanceExtensions(&instanceCreateInfo.enabledExtensionCount); + char const *const *instanceExtensions = SDL_Vulkan_GetInstanceExtensions((int *)&instanceCreateInfo.enabledExtensionCount); const char **instanceExtensionsCopy = SDL_calloc(instanceCreateInfo.enabledExtensionCount + 2, sizeof(const char *)); for (uint32_t i = 0; i < instanceCreateInfo.enabledExtensionCount; i++) { diff --git a/src/test/SDL_test_common.c b/src/test/SDL_test_common.c index afbe7f5c8c..f463aac3c0 100644 --- a/src/test/SDL_test_common.c +++ b/src/test/SDL_test_common.c @@ -1048,8 +1048,8 @@ static void SDLTest_PrintRenderer(SDL_RendererInfo *info) SDL_snprintfcat(text, sizeof(text), ")"); SDL_Log("%s\n", text); - (void)SDL_snprintf(text, sizeof(text), " Texture formats (%" SDL_PRIu32 "): ", info->num_texture_formats); - for (i = 0; i < (int)info->num_texture_formats; ++i) { + (void)SDL_snprintf(text, sizeof(text), " Texture formats (%d): ", info->num_texture_formats); + for (i = 0; i < info->num_texture_formats; ++i) { if (i > 0) { SDL_snprintfcat(text, sizeof(text), ", "); } diff --git a/src/video/SDL_video.c b/src/video/SDL_video.c index a1fb6b3fb3..2dc709448b 100644 --- a/src/video/SDL_video.c +++ b/src/video/SDL_video.c @@ -313,7 +313,7 @@ static int SDL_CreateWindowTexture(SDL_VideoDevice *_this, SDL_Window *window, U /* Find the first format with or without an alpha channel */ *format = info.texture_formats[0]; - for (i = 0; i < (int)info.num_texture_formats; ++i) { + for (i = 0; i < info.num_texture_formats; ++i) { if (!SDL_ISPIXELFORMAT_FOURCC(info.texture_formats[i]) && transparent == SDL_ISPIXELFORMAT_ALPHA(info.texture_formats[i])) { *format = info.texture_formats[i]; @@ -5217,9 +5217,9 @@ void SDL_Vulkan_UnloadLibrary(void) } } -char const* const* SDL_Vulkan_GetInstanceExtensions(Uint32 *count) +char const* const* SDL_Vulkan_GetInstanceExtensions(int *count) { - return _this->Vulkan_GetInstanceExtensions(_this, count); + return _this->Vulkan_GetInstanceExtensions(_this, (Uint32 *)count); } SDL_bool SDL_Vulkan_CreateSurface(SDL_Window *window, diff --git a/test/testffmpeg_vulkan.c b/test/testffmpeg_vulkan.c index 397b77919c..3bf92ce386 100644 --- a/test/testffmpeg_vulkan.c +++ b/test/testffmpeg_vulkan.c @@ -206,7 +206,7 @@ static int createInstance(VulkanVideoContext *context) VkApplicationInfo appInfo = { 0 }; VkInstanceCreateInfo instanceCreateInfo = { 0 }; VkResult result; - char const *const *instanceExtensions = SDL_Vulkan_GetInstanceExtensions(&instanceCreateInfo.enabledExtensionCount); + char const *const *instanceExtensions = SDL_Vulkan_GetInstanceExtensions((int *)&instanceCreateInfo.enabledExtensionCount); appInfo.sType = VK_STRUCTURE_TYPE_APPLICATION_INFO; appInfo.apiVersion = VK_API_VERSION_1_3; diff --git a/test/testvulkan.c b/test/testvulkan.c index dcd0ebb1b1..732a23fd0c 100644 --- a/test/testvulkan.c +++ b/test/testvulkan.c @@ -229,7 +229,7 @@ static void createInstance(void) instanceCreateInfo.sType = VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO; instanceCreateInfo.pApplicationInfo = &appInfo; - instanceCreateInfo.ppEnabledExtensionNames = SDL_Vulkan_GetInstanceExtensions(&instanceCreateInfo.enabledExtensionCount); + instanceCreateInfo.ppEnabledExtensionNames = SDL_Vulkan_GetInstanceExtensions((int *)&instanceCreateInfo.enabledExtensionCount); result = vkCreateInstance(&instanceCreateInfo, NULL, &vulkanContext->instance); if (result != VK_SUCCESS) { vulkanContext->instance = VK_NULL_HANDLE;