eden-emu/SDL
15
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2025-05-21 12:18:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Make sure stdio handles are in blocking mode

Browse source 
Standard I/O doesn't work well with non-blocking handles, so make sure any pipes are in blocking mode before launching child processes.

Fixes https://github.com/libsdl-org/SDL/issues/10998
This commit is contained in:
Sam Lantinga 2024-10-14 21:45:41 -07:00
parent bb764e3106
commit afee27a530
3 changed files with 31 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
test/testprocess.c
View file

@ -667,6 +667,8 @@ static int process_testMultiprocessStdinToStdout(void *arg)
const char *process_args[] = {
data->childprocess_path,
"--stdin-to-stdout",
"--log-stdin",
NULL,
NULL,
};
SDL_Process *process1 = NULL;
@ -680,6 +682,7 @@ static int process_testMultiprocessStdinToStdout(void *arg)
size_t total_read = 0;
bool finished;
process_args[3] = "child1-stdin.txt";
process1 = SDL_CreateProcess(process_args, true);
SDLTest_AssertCheck(process1 != NULL, "SDL_CreateProcess()");
if (!process1) {
@ -692,6 +695,7 @@ static int process_testMultiprocessStdinToStdout(void *arg)
SDL_SetPointerProperty(props, SDL_PROP_PROCESS_CREATE_STDIN_POINTER, SDL_GetPointerProperty(SDL_GetProcessProperties(process1), SDL_PROP_PROCESS_STDOUT_POINTER, NULL));
SDL_SetNumberProperty(props, SDL_PROP_PROCESS_CREATE_STDOUT_NUMBER, SDL_PROCESS_STDIO_APP);
SDLTest_AssertPass("About to call SDL_CreateProcessWithProperties");
process_args[3] = "child2-stdin.txt";
process2 = SDL_CreateProcessWithProperties(props);
SDL_DestroyProperties(props);
SDLTest_AssertCheck(process2 != NULL, "SDL_CreateProcess()");