eden-emu/SDL
15
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2025-05-25 22:19:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Stack allocation never happened, so explicitly allocate the path

Browse source
This commit is contained in:
Sam Lantinga 2024-06-05 05:48:39 -07:00
parent 4836fd1e70
commit 7b14fcb4d9
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/file/SDL_iostream.c
View file

@ -577,13 +577,11 @@ SDL_IOStream *SDL_IOFromFile(const char *file, const char *mode)
return SDL_IOFromFP(fp, SDL_TRUE); return SDL_IOFromFP(fp, SDL_TRUE);
} else { } else {
/* Try opening it from internal storage if it's a relative path */ /* Try opening it from internal storage if it's a relative path */
// !!! FIXME: why not just "char path[PATH_MAX];" char *path = NULL;
char *path = SDL_stack_alloc(char, PATH_MAX); SDL_asprintf(&path, "%s/%s", SDL_AndroidGetInternalStoragePath(), file);
if (path) { if (path) {
SDL_snprintf(path, PATH_MAX, "%s/%s",
SDL_AndroidGetInternalStoragePath(), file);
FILE *fp = fopen(path, mode); FILE *fp = fopen(path, mode);
SDL_stack_free(path); SDL_free(path);
if (fp) { if (fp) {
if (!IsRegularFileOrPipe(fp)) { if (!IsRegularFileOrPipe(fp)) {
fclose(fp); fclose(fp);