eden-emu/SDL
20
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

thread: fix inconsistent return values

Browse source 
- SDL_CreateMutex returns NULL when the creation fails (ngage)
- SDL_SemValue returns 0 when the semaphore is NULL (n3ds)
This commit is contained in:
pionere 2022-11-29 11:18:30 +01:00 • committed by Ryan C. Gordon
parent b5076ef5e3
commit 6875e1c262
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/thread/n3ds/SDL_syssem.c
View file

@ -113,7 +113,8 @@ Uint32
SDL_SemValue(SDL_sem *sem) SDL_SemValue(SDL_sem *sem)
{ {
if (sem == NULL) { if (sem == NULL) {
return SDL_InvalidParamError("sem"); SDL_InvalidParamError("sem");
return 0;
} }
return sem->semaphore.current_count; return sem->semaphore.current_count;
} }

1
src/thread/ngage/SDL_sysmutex.cpp
View file

@ -47,6 +47,7 @@ SDL_CreateMutex(void)
TInt status = CreateUnique(NewMutex, &rmutex, NULL); TInt status = CreateUnique(NewMutex, &rmutex, NULL);
if (status != KErrNone) { if (status != KErrNone) {
SDL_SetError("Couldn't create mutex."); SDL_SetError("Couldn't create mutex.");
return NULL;
} }
SDL_mutex* mutex = new /*(ELeave)*/ SDL_mutex; SDL_mutex* mutex = new /*(ELeave)*/ SDL_mutex;
mutex->handle = rmutex.Handle(); mutex->handle = rmutex.Handle();