eden-emu/SDL
15
0
Fork 0
mirror of https://github.com/libsdl-org/SDL.git synced 2025-06-02 01:47:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

testcamera: don't pick a frame size larger than the maximum texture size

Browse source 
Ran into this on a Huawei Y6 phone, where the back facing camera can generate 4160x2000 frames, but the maximum texture size was 4096x4096
This commit is contained in:
Sam Lantinga 2024-12-29 09:41:00 -08:00
parent 6e1177ac03
commit 5c84d38822
1 changed files with 30 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

39
test/testcamera.c
View file

@ -19,7 +19,6 @@ static SDL_Window *window = NULL;
static SDL_Renderer *renderer = NULL; static SDL_Renderer *renderer = NULL;
static SDLTest_CommonState *state = NULL; static SDLTest_CommonState *state = NULL;
static SDL_Camera *camera = NULL; static SDL_Camera *camera = NULL;
static SDL_CameraSpec spec;
static SDL_Texture *texture = NULL; static SDL_Texture *texture = NULL;
static bool texture_updated = false; static bool texture_updated = false;
static SDL_Surface *frame_current = NULL; static SDL_Surface *frame_current = NULL;
@ -46,12 +45,34 @@ static void PrintCameraSpecs(SDL_CameraID camera_id)
} }
} }
static void PickCameraSpec(SDL_CameraID camera_id, SDL_CameraSpec *spec)
{
SDL_CameraSpec **specs = SDL_GetCameraSupportedFormats(camera_id, NULL);
SDL_zerop(spec);
if (specs) {
int i;
int max_size = SDL_GetNumberProperty(SDL_GetRendererProperties(state->renderers[0]), SDL_PROP_RENDERER_MAX_TEXTURE_SIZE_NUMBER, 0);
for (i = 0; specs[i]; ++i) {
const SDL_CameraSpec *s = specs[i];
if (s->width <= max_size && s->height <= max_size) {
SDL_copyp(spec, s);
break;
}
}
SDL_free(specs);
}
}
SDL_AppResult SDL_AppInit(void **appstate, int argc, char *argv[]) SDL_AppResult SDL_AppInit(void **appstate, int argc, char *argv[])
{ {
char window_title[128]; char window_title[128];
int devcount = 0; int devcount = 0;
int i; int i;
const char *camera_name = NULL; const char *camera_name = NULL;
SDL_CameraSpec spec;
/* Initialize test framework */ /* Initialize test framework */
state = SDLTest_CommonCreateState(argv, SDL_INIT_VIDEO | SDL_INIT_CAMERA); state = SDLTest_CommonCreateState(argv, SDL_INIT_VIDEO | SDL_INIT_CAMERA);
@ -132,6 +153,8 @@ SDL_AppResult SDL_AppInit(void **appstate, int argc, char *argv[])
camera_id = device; camera_id = device;
} }
SDL_Log(" - Camera #%d: %s %s", i, posstr, name); SDL_Log(" - Camera #%d: %s %s", i, posstr, name);
PrintCameraSpecs(device);
} }
if (!camera_id) { if (!camera_id) {
@ -152,13 +175,8 @@ SDL_AppResult SDL_AppInit(void **appstate, int argc, char *argv[])
return SDL_APP_FAILURE; return SDL_APP_FAILURE;
} }
PrintCameraSpecs(camera_id); PickCameraSpec(camera_id, &spec);
camera = SDL_OpenCamera(camera_id, &spec);
SDL_CameraSpec *pspec = &spec;
spec.framerate_numerator = 30;
spec.framerate_denominator = 1;
camera = SDL_OpenCamera(camera_id, pspec);
if (!camera) { if (!camera) {
SDL_Log("Failed to open camera device: %s", SDL_GetError()); SDL_Log("Failed to open camera device: %s", SDL_GetError());
return SDL_APP_FAILURE; return SDL_APP_FAILURE;
@ -188,6 +206,8 @@ static int FlipCamera(void)
} }
if (nextcam) { if (nextcam) {
SDL_CameraSpec spec;
SDL_Log("Flip camera!"); SDL_Log("Flip camera!");
if (frame_current) { if (frame_current) {
@ -202,7 +222,8 @@ static int FlipCamera(void)
texture = NULL; /* will rebuild when new camera is approved. */ texture = NULL; /* will rebuild when new camera is approved. */
} }
camera = SDL_OpenCamera(nextcam, NULL); PickCameraSpec(nextcam, &spec);
camera = SDL_OpenCamera(nextcam, &spec);
if (!camera) { if (!camera) {
SDL_Log("Failed to open camera device: %s", SDL_GetError()); SDL_Log("Failed to open camera device: %s", SDL_GetError());
return SDL_APP_FAILURE; return SDL_APP_FAILURE;