eden-emu/Catch2
20
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove the new tests from approvals

Browse source 
They lead to stringification of file (which is ok) and file line
(not ok) to the approvals, which makes them exceedingly brittle
and not worth approval testing. Instead we just run them as part
of the base test run.
This commit is contained in:
Martin Hořeňovský 2019-08-09 11:08:23 +02:00
parent edcfd7fc62
commit ebe6a07c23
No known key found for this signature in database
GPG key ID: DE48307B8B0D381A
6 changed files with 8 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

2
projects/SelfTest/IntrospectiveTests/Details.tests.cpp
View file

@ -10,7 +10,7 @@
#pragma warning(disable:4702) // unreachable code in the macro expansions
#endif
TEST_CASE("Check that our error handling macros throw the right exceptions", "[!throws][internals]") {
TEST_CASE("Check that our error handling macros throw the right exceptions", "[!throws][internals][approvals]") {
REQUIRE_THROWS_AS(CATCH_INTERNAL_ERROR(""), std::logic_error);
REQUIRE_THROWS_AS(CATCH_ERROR(""), std::domain_error);
REQUIRE_THROWS_AS(CATCH_RUNTIME_ERROR(""), std::runtime_error);