eden-emu/Catch2
15
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix various useful clang-tidy warnings

Browse source 
* bugprone-branch-clone
* bugprone-copy-constructor-init
* bugprone-empty-catch
* bugprone-sizeof-expression
* bugprone-switch-missing-default-case
* bugprone-unused-local-non-trivial-variable
* clang-analyzer-core.uninitialized.Assign
* clang-analyzer-cplusplus.Move
* clang-analyzer-optin.cplusplus.VirtualCall
* modernize-loop-convert
* modernize-raw-string-literal
* modernize-use-equals-default
* modernize-use-override
* modernize-use-using
* performance-avoid-endl
* performance-inefficient-string-concatenation
* performance-inefficient-vector-operation
* performance-noexcept-move-constructor
* performance-unnecessary-value-param (and improve generator example)
* readability-duplicate-include
* readability-inconsistent-declaration-parameter-name
* readability-non-const-parameter
* readability-redundant-casting
* readability-redundant-member-init
* readability-redundant-smartptr-get
* readability-static-accessed-through-instance
* unused variable in amalgamted tests
This commit is contained in:
Martin Jeřábek 2024-03-01 11:15:27 +01:00 • committed by Martin Hořeňovský
parent 7677c1658e
commit cde3509664
39 changed files with 86 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

14
tests/SelfTest/UsageTests/Benchmark.tests.cpp
View file

@ -90,14 +90,14 @@ TEST_CASE("Benchmark containers", "[!benchmark]") {
};
REQUIRE(v.size() == size);
int array[size];
int array[size] {};
BENCHMARK("A fixed size array that should require no allocations") {
for (int i = 0; i < size; ++i)
array[i] = i;
};
int sum = 0;
for (int i = 0; i < size; ++i)
sum += array[i];
for (int val : array)
sum += val;
REQUIRE(sum > size);
SECTION("XYZ") {
@ -121,8 +121,8 @@ TEST_CASE("Benchmark containers", "[!benchmark]") {
runs = benchmarkIndex;
};
for (size_t i = 0; i < v.size(); ++i) {
REQUIRE(v[i] == runs);
for (int val : v) {
REQUIRE(val == runs);
}
}
}
@ -135,8 +135,8 @@ TEST_CASE("Benchmark containers", "[!benchmark]") {
for (int i = 0; i < size; ++i)
v[i] = generated;
};
for (size_t i = 0; i < v.size(); ++i) {
REQUIRE(v[i] == generated);
for (int val : v) {
REQUIRE(val == generated);
}
}