eden-emu/Catch2
19
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Pass other StringRef arguments by value instead of by-ref

Browse source 
Apart from being clearer, it also improves the overall codesize
of the implementation library, and should improve the performance
as well, by removing one level of indirection.
This commit is contained in:
Martin Hořeňovský 2021-05-14 23:45:59 +02:00
parent 074017f5ad
commit 61e16416a9
No known key found for this signature in database
GPG key ID: DE48307B8B0D381A
11 changed files with 19 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/catch2/internal/catch_assertion_handler.hpp
View file

@ -32,7 +32,7 @@ namespace Catch {
public:
AssertionHandler
( StringRef const& macroName,
( StringRef macroName,
SourceLineInfo const& lineInfo,
StringRef capturedExpression,
ResultDisposition::Flags resultDisposition );
@ -49,7 +49,7 @@ namespace Catch {
}
void handleExpr( ITransientExpression const& expr );
void handleMessage(ResultWas::OfType resultType, StringRef const& message);
void handleMessage(ResultWas::OfType resultType, StringRef message);
void handleExceptionThrownAsExpected();
void handleUnexpectedExceptionNotThrown();
@ -64,7 +64,7 @@ namespace Catch {
auto allowThrows() const -> bool;
};
void handleExceptionMatchExpr( AssertionHandler& handler, std::string const& str, StringRef const& matcherString );
void handleExceptionMatchExpr( AssertionHandler& handler, std::string const& str, StringRef matcherString );
} // namespace Catch