JPikachu/eden
1
0
Fork 0
forked from eden-emu/eden
Code Pull requests Activity

loader: Make the Load() function take a process as a regular reference, not a SharedPtr

Browse source 
A process should never require being reference counted in this
situation. If the handle to a process is freed before this function is
called, it's definitely a bug with our lifetime management, so we can
put the requirement in place for the API that the process must be a
valid instance.
This commit is contained in:
Lioncash 2018-09-29 15:57:40 -04:00
parent 0921558a9f
commit a63e6f9dfd
18 changed files with 28 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/core.cpp
View file

@ -202,7 +202,7 @@ struct System::Impl {
return init_result;
}
const Loader::ResultStatus load_result{app_loader->Load(kernel.CurrentProcess())};
const Loader::ResultStatus load_result{app_loader->Load(*kernel.CurrentProcess())};
if (load_result != Loader::ResultStatus::Success) {
LOG_CRITICAL(Core, "Failed to load ROM (Error {})!", static_cast<int>(load_result));
Shutdown();